Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate negative query boost (#34486) #34512

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Deprecate negative query boost (#34486) #34512

merged 1 commit into from
Oct 16, 2018

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Oct 16, 2018

This is the backport of #34486

Relates #33309

@jimczi
Deprecate negative query boost (elastic#34486)
45b9bc3 
This change deprecates negative query boosts. Negative scores are not allowed in Lucene 8 so
it is easier to just disallow negative boosts entirely.

Relates elastic#33309
@jimczi jimczi added :Search/Search Search-related issues that do not fall into other categories >deprecation v6.5.0 labels Oct 16, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

colings86
colings86 approved these changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimczi jimczi merged commit 679bc36 into elastic:6.x Oct 16, 2018
@jimczi jimczi deleted the deprecate_negative_boosts branch October 16, 2018 14:44
@Mpdreamz Mpdreamz mentioned this pull request Dec 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colings86 colings86 colings86 approved these changes

Assignees
No one assigned
Labels
>deprecation :Search/Search Search-related issues that do not fall into other categories v6.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimczi @elasticmachine @colings86